Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column header not updated on new epoch #159

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

KatunaNorbert
Copy link
Member

Fixes #152.

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
predictoor-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 1:34pm

@idiom-bytes
Copy link
Member

idiom-bytes commented Sep 6, 2023

With this update,

The user sees this after ~4 seconds
image

And then needs to wait ~28 seconds to see the remainder.
The UI then continues to say "Loading..." rather than just showing information about the subscriptions.
image

I think something needs to be reviewed here.

@KatunaNorbert
Copy link
Member Author

That's due to the beauty of working with Ganache.
I'm not sure what's going on in there but on test network it's working well, maybe Ganache was not updated.

@KatunaNorbert
Copy link
Member Author

It does appear finally, but my guess is that the network it's very slow
Screenshot 2023-09-07 at 10 23 10

Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column times are updating as epochs complete, and new ones are appended.

@idiom-bytes idiom-bytes merged commit 4bb13eb into main Sep 7, 2023
1 check passed
@idiom-bytes idiom-bytes deleted the issue-152-column-header-not-updated branch September 7, 2023 18:24
@idiom-bytes
Copy link
Member

idiom-bytes commented Sep 7, 2023

I approved/merged as the table seemed to be updating correctly.

I wrote this ticket so we can address the code and making things more legible/easier to follow.
#169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Columns header time not updated.
2 participants